-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deno process crashes while using node-fetch 2.x.x #1725
Labels
Comments
joamag
changed the title
Deno crashes while using node-fetech 2.x.x
Deno process crashes while using node-fetch 2.x.x
Mar 17, 2023
PR added #1726 @jimmywarting |
Why do you want to use node-fetch when deno have it built in already? |
Transitive dependency of a node API client package that makes use of node-fetch |
🎉 This issue has been resolved in version 2.6.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using deno (which now supports npm packages) and node-fetch 2.x.x yields an unhandled error due to "socket" event not being triggered.
I believe keeping deno compatibility is not a priority but a simple
undefined
testing in the socket variable should fix the issue.Reproduction
Steps to reproduce the behavior:
fixResponseChunkedTransferBadEnding()
Expected behavior
No unhandled error is raised and the fetch requests are handled properly.
Screenshots
Your Environment
Additional context
This is verified only while using deno and not in node.js.
The text was updated successfully, but these errors were encountered: