Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno process crashes while using node-fetch 2.x.x #1725

Closed
joamag opened this issue Mar 17, 2023 · 4 comments
Closed

Deno process crashes while using node-fetch 2.x.x #1725

joamag opened this issue Mar 17, 2023 · 4 comments

Comments

@joamag
Copy link

joamag commented Mar 17, 2023

Using deno (which now supports npm packages) and node-fetch 2.x.x yields an unhandled error due to "socket" event not being triggered.

I believe keeping deno compatibility is not a priority but a simple undefined testing in the socket variable should fix the issue.

Reproduction

Steps to reproduce the behavior:

  1. Use deno and node-fetch
  2. Perform a simple fetch operation (ex: GET)
  3. Verify that the deno process has exited with an Uncaught error on fixResponseChunkedTransferBadEnding()

Expected behavior

No unhandled error is raised and the fetch requests are handled properly.

Screenshots

image

Your Environment

software version
node-fetch v2.6.8+
deno v1.31.3
Operating System Windows

Additional context

This is verified only while using deno and not in node.js.

@joamag joamag added the bug label Mar 17, 2023
@joamag joamag changed the title Deno crashes while using node-fetech 2.x.x Deno process crashes while using node-fetch 2.x.x Mar 17, 2023
@joamag
Copy link
Author

joamag commented Mar 17, 2023

PR added #1726 @jimmywarting

@jimmywarting
Copy link
Collaborator

Why do you want to use node-fetch when deno have it built in already?
...so those NodeJS v18

@joamag
Copy link
Author

joamag commented Mar 18, 2023

Why do you want to use node-fetch when deno have it built in already? ...so those NodeJS v18

Transitive dependency of a node API client package that makes use of node-fetch

@github-actions
Copy link

🎉 This issue has been resolved in version 2.6.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants