Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: readme - non ESM example #1707

Merged
merged 1 commit into from Feb 1, 2023
Merged

docs: readme - non ESM example #1707

merged 1 commit into from Feb 1, 2023

Conversation

Michal-Miky-Jankovsky
Copy link
Contributor

Purpose

Fix old example in the README.md file.

Changes

require -> import

Additional information

according to different part of the same document

node-fetch from v3 is an ESM-only module - you are not able to import it with require()

@jimmywarting jimmywarting changed the title fix: readme - non ESM example docs: readme - non ESM example Jan 30, 2023
LinusU
LinusU approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LinusU LinusU merged commit 8ced5b9 into node-fetch:main Feb 1, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@data-sync-user data-sync-user mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

@jimmywarting jimmywarting jimmywarting approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Michal-Miky-Jankovsky @LinusU @jimmywarting