Ability to catch promise rejections from background refreshes #637
+105
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kauhsa
commented
Jan 30, 2024
Kauhsa
force-pushed
the
on-background-refresh-error
branch
2 times, most recently
from
4a40bc2 to
6e35c40
Compare
Kauhsa
commented
Jan 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 320 327 +7
Branches 79 81 +2
=========================================
+ Hits 320 327 +7 ☔ View full report in Codecov by Sentry. |
|
@Kauhsa can we get an update on this? |
Kauhsa
force-pushed
the
on-background-refresh-error
branch
from
6e35c40 to
10b8d98
Compare
Sure. Rebased (if that is what you meant). |
|
@Kauhsa - thanks so much for adding this in and updating the readme. We will get this published in the next couple weeks. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
onBackgroundRefreshErrorconfiguration option, which makes it possible to handle promise rejections originating from background refreshes.As it stands now, depending on your Node version, process might crash.
process.on('uncaughtException', ...)fixes that, but we missed a bit more... targeted approach to handling these errors, so here is a PR.