Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move got tests into got folder #2542

Merged
merged 3 commits into from
Oct 30, 2023
Merged

test: move got tests into got folder #2542

merged 3 commits into from
Oct 30, 2023

Conversation

Uzlopak
Copy link
Member

@Uzlopak Uzlopak commented Oct 30, 2023

This is a preparation PR. It moves all current tests, which are using got into test/got. This has the benefit, that when we add fetch capability, we just need to copy the folder and replace got calls with fetch.

@gr2m
Copy link
Member

gr2m commented Oct 30, 2023

hmm any idea what the failing test might be? npm run lint:ts works fine for me locally 🤔

Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the failing test, code changes look good to me

@Uzlopak
Copy link
Member Author

Uzlopak commented Oct 30, 2023

@gr2m
How can we merge without releasing?

@gr2m
Copy link
Member

gr2m commented Oct 30, 2023

How can we merge without releasing?

releases only occur for fix: and feat: prefixes in the commit header, or BREAKING CHANGE: in the commit body, see https://github.com/nock/nock/blob/main/CONTRIBUTING.md#commit-message-conventions

@gr2m gr2m changed the title move got tests into got folder test: move got tests into got folder Oct 30, 2023
@gr2m gr2m merged commit 1d52210 into main Oct 30, 2023
19 checks passed
@gr2m gr2m deleted the move-got-test branch October 30, 2023 20:25
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 13.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants