Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add rawHeaders in mock docs #2527

Merged
merged 1 commit into from Oct 13, 2023
Merged

docs: add rawHeaders in mock docs #2527

merged 1 commit into from Oct 13, 2023

Conversation

kschat
Copy link
Contributor

@kschat kschat commented Oct 13, 2023

This had my team questioning our sanity for a good while, hoping to save future devs some time. 馃槃

gr2m
gr2m approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I thought that nock does both, but I probably mis-remember 馃し馃徏 I won't be able to look into the history of this so going ahead trust y'all and merge it in. Thank you for helping the community 馃拹

@gr2m gr2m merged commit c897aa3 into nock:main Oct 13, 2023
19 checks passed
@kschat kschat deleted the patch-1 branch October 13, 2023 20:06
@github-actions
Copy link

馃帀 This PR is included in version 13.3.5 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

@cdaringe cdaringe cdaringe approved these changes

@SlackJaw74 SlackJaw74 SlackJaw74 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kschat @gr2m @cdaringe @SlackJaw74