fix: call fs.createReadStream lazily
#2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello dear nock maintainers! I'd like to know if there's any particular reason this PR (or either of the other two PRs I opened at the same time, #2355 and #2356) have not been looked at yet. For starters, my branch is now out of date, and the CONTRIBUTING.md file says I should be targeting a beta branch (but there's none). But aside from that, is there anything wrong or missing? Updating merging the latest changes to the branch is something that can be done orthogonally from the review. |
mbargiel
changed the title
fs.createReadStream lazily
mbargiel
force-pushed
the
feature/fix-2354-lazy-replywithfile
branch
from
aed6c64
to
a6490c3
Compare
mbargiel
force-pushed
the
feature/fix-2354-lazy-replywithfile
branch
from
a6490c3
to
e344eb5
Compare
|
@mikicho Branch updated - rebased on top of main, and I also split my one commit into 3 (separated individual test additions from the fix itself) |
Uzlopak
reviewed
Feb 17, 2024
Uzlopak
reviewed
Feb 17, 2024
Uzlopak
force-pushed
the
feature/fix-2354-lazy-replywithfile
branch
from
a09e296
to
73757d4
Compare
|
🎉 This PR is included in version 13.5.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
replyWithFile, a ReadStream is immediately created wih the file path. When the mock is hit, another ReadStream is created immediately if the interceptor is configured to be set again or if its scope has_persistset. When callingnock.removeInterceptor, the ReadStream isn't closed.As a result, it's not possible to delete the folder where the file exists on Windows unless implementing a workaround like multiple
fs.rmcalls.This PR removes the eager
fs.createReadStreamcall when setting up the interceptor and instead configures the route to createthe stream lazily, in a callback invoked when intercepting a call. There is no longer any need for
replyWithFile-related logic inInterceptor#markConsumed().I also added an extra test for
replyWithFile+persist(), which I think makes coverage a bit more complete.Fixes #2354