fix: remove duplicates from activeMocks() and pendingMocks()
#2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was unable to merge the master to this PR to resolve the conflict, so I will wait for the contributor to do it. If not, I will open a new PR. |
|
Woah, that's quite the necro 😅 I'll see if I can find some time to remember what this was about and solve the merge conflict. (Note: I have two other PRs fixing other bugs that also have merge conflicts.) |
mbargiel
force-pushed
the
feature/fix-2352-remove-extraneous-active-mocks
branch
from
6e01cf0
to
0b6ab12
Compare
|
Fixed the formatting and also confirmed that test is indeed failing on c366ed1 |
|
🎉 This PR is included in version 13.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
interceptorScopes()function is used byactiveMocks()andpendingMocks()to retrieve the list of all scopes. That list is built by concatenating the scopes of every interceptor. When multiple interceptors are registered on the same scope, the scope will be returned multiple times, causingactiveMocks()andpendingMocks()to include duplicates.This PR fixes the issue by ensuring there is no duplicate returned by
interceptorScopes().Fixes #2352 (and #600, which also reported this issue)