Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add query to filter attributes to GetRepositoryAttributesUseCase #34

Merged

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Feb 22, 2024

This pull request adds the GetRepositoryAttributesRequestQuery interface to the GetRepositoryAttributesUseCase. This allows for more specific querying of attributes when retrieving repository attributes.

Copy link

coderabbitai bot commented Feb 22, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@jkoenig134
Copy link
Member

two things:

  1. remove these // default: true comments or make these jsdocs, so that they are exposed to the runtime user
  2. runtime version bump (minor)

Copy link
Contributor

@Milena-Czierlinski Milena-Czierlinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add a query to GetRepositoryAttributes, should we also do it for GetOwnSharedAttributes and GetPeerSharedAttributes?

@sebbi08
Copy link
Contributor Author

sebbi08 commented Feb 22, 2024

@Milena-Czierlinski

If we add a query to GetRepositoryAttributes, should we also do it for GetOwnSharedAttributes and GetPeerSharedAttributes?

The both already have it do you mean GetVersionsOfAttribute and GetSharedVersionsOfRepositoryAttribute

@Milena-Czierlinski
Copy link
Contributor

Indeed, they do. My bad. Regarding GetVersionsOfAttribute and GetSharedVersionsOfRepositoryAttribute, I don't think it is necessary to add a query there, since mainly only the value changes.

@jkoenig134
Copy link
Member

Both of these UseCases (GetVersionsOfAttribute and GetSharedVersionsOfRepositoryAttribute) do not need queries as they have an id and therefore act on ONE attribute 👍🏼

@jkoenig134
Copy link
Member

@sebbi08 runtime bump and then ready to go!

slavistan
slavistan previously approved these changes Feb 28, 2024
Copy link
Member

@jkoenig134 jkoenig134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I block this until it get its version bumps.

jkoenig134
jkoenig134 previously approved these changes Feb 28, 2024
@jkoenig134
Copy link
Member

merging this b/c @sebbi08 is unavailable.

@jkoenig134 jkoenig134 merged commit e94e677 into main Feb 29, 2024
16 checks passed
@jkoenig134 jkoenig134 deleted the feature/add-query-to-get-repository-attributes-usecase branch February 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants