New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/add query to filter attributes to GetRepositoryAttributesUseCase #34
feature/add query to filter attributes to GetRepositoryAttributesUseCase #34
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
two things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add a query to GetRepositoryAttributes, should we also do it for GetOwnSharedAttributes and GetPeerSharedAttributes?
packages/runtime/src/useCases/consumption/attributes/GetRepositoryAttributes.ts
Outdated
Show resolved
Hide resolved
packages/runtime/src/useCases/consumption/attributes/GetRepositoryAttributes.ts
Outdated
Show resolved
Hide resolved
The both already have it do you mean |
Indeed, they do. My bad. Regarding |
Both of these UseCases ( |
packages/runtime/src/useCases/consumption/attributes/GetRepositoryAttributes.ts
Show resolved
Hide resolved
@sebbi08 runtime bump and then ready to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I block this until it get its version bumps.
merging this b/c @sebbi08 is unavailable. |
This pull request adds the GetRepositoryAttributesRequestQuery interface to the GetRepositoryAttributesUseCase. This allows for more specific querying of attributes when retrieving repository attributes.