New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/decouple runtime tests #29
Conversation
create helper methods in the testUtils
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This reverts commit 56e1fbc.
add return parameters
…nmshd/runtime into refactor/decouple-runtime-tests
…nmshd/runtime into refactor/decouple-runtime-tests
In
|
packages/runtime/src/extensibility/facades/consumption/IncomingRequestsFacade.ts
Outdated
Show resolved
Hide resolved
All tests, except for those mentioned, do run together and in isolation. Great success👍 |
I like the previous name hinting at the usage - and as someone who has struggled with excess attributes, I understand cleanup to mean delete |
…ntime into refactor/decouple-runtime-tests
…nmshd/runtime into refactor/decouple-runtime-tests
…nmshd/runtime into refactor/decouple-runtime-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not bumping the version since we only changed tests and no implementation code.
create helper methods in the testUtils