Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding user_scope in authorizationParams #11

Conversation

jonstorer
Copy link
Contributor

@jonstorer jonstorer commented May 8, 2023

Slack's OAuth2 implementation expects bot token scopes at "scope" and user token scopes at "user_scope". Please let me know if there's anything else you'd like me to do before this can be merged.

https://api.slack.com/authentication/oauth-v2#asking

There is another module that has enabled this, but I'd prefer to make this change in the most popular passport strategy.

https://www.npmjs.com/package/@workablehr/passport-slack-v2

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jonstorer jonstorer closed this May 8, 2023
@jonstorer jonstorer reopened this May 8, 2023
@nmaves nmaves merged commit 06a398f into nmaves:master May 8, 2023
@nmaves
Copy link
Owner

nmaves commented May 8, 2023

@jonstorer would you be able to test out the next version I just published?

npm install passport-slack-oauth2@next

@jonstorer
Copy link
Contributor Author

jonstorer commented May 10, 2023

@nmaves it works!

Also, I'm working on some changes to bring Slacks full OAuth2 v2 flow into this lib. Which would resolved #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants