Change in Polish encodings of udhr corpus reader #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change will make the link look more like a link and also ensure that it's visible in both: dark and light mode
…ithub.com/hamiltonianflow/nltk into hamiltonianflow-fix/polish-encoding-in-udhr-reader-change
|
Thank you for finding this! Your fix is simple and proper too. I've added a simple test in 0526ad5 to verify that this will continue to work in the future (and I bunged up the git history of this PR somewhat... Apologies) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification in
UdhrCorpusReadercorpus reader class, which changes the encoding used for Polish language filesPolish-Latin2andPolish_Polski-Latin2fromISO-8859-2tocp1250, so that they are properly read.Fixes #3037