Avoid handling ping after close frame has been sent #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you have time to take a quick look at this ? |
nhooyr
force-pushed
the
dev
branch
2 times, most recently
from
825873c
to
9b5a15b
Compare
nhooyr
force-pushed
the
dev
branch
5 times, most recently
from
3500fce
to
a94999f
Compare
|
Unfortunately this doesn't work. writeFrame already has a check like this built in so it makes sense it doesn't work. There is definitely a bug in #298, but need to dig deeper to figure out what. See the test I added to your commit, it still fails. |
nhooyr
force-pushed
the
dev
branch
2 times, most recently
from
268b079
to
e4879ab
Compare
|
See e4879ab for the test |
nhooyr
added a commit
that referenced
this pull request
Oct 19, 2023
Closes #298 Closes #394 The close frame was being received from the peer before we were able to reset our write timeout and so we thought the write kept failing but it never was... Thanks @univerio and @bhallionOhbibi
|
Fixed in dev, see 28c6709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298