Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netconn.go: Disable read limit on WebSocket #254

Merged
merged 2 commits into from Jan 9, 2021
Merged

netconn.go: Disable read limit on WebSocket #254

merged 2 commits into from Jan 9, 2021

Conversation

nhooyr
Copy link
Owner

@nhooyr nhooyr commented Jul 4, 2020

Closes #245

@nhooyr
Copy link
Owner Author

nhooyr commented Jul 4, 2020

Please review @cmoog

@nhooyr
Copy link
Owner Author

nhooyr commented Jul 4, 2020

Will need a test.

@nhooyr nhooyr changed the title netconn: Disable read limit on WebSocket netconn.go: Disable read limit on WebSocket Jul 4, 2020
@nhooyr nhooyr merged commit 642a013 into dev Jan 9, 2021
@nhooyr nhooyr deleted the netconn-readlimit branch January 9, 2021 13:15
@nhooyr nhooyr mentioned this pull request Mar 14, 2023
Closed
tmessi added a commit to hashicorp/boundary that referenced this pull request Oct 6, 2023
@tmessi
fix(cli): Remove websocket message size limit
1d4472c 
When the boundary client establishes a connection to the websocket used
to communicate with a worker, it was configured with a max websocket
message size of 32KiB. This was the default behavior for v1.8.7 of
nhooyr/websocket. However, there are cases where the worker can send
messages to the client that are larger than 32KiB. When this happens the
client returns an error and terminates the connection.

Notably this seems to only currently impact sessions made to SSH
Targets, although it could theoretically impact any target type
depending on the details of how the worker performs the writing of the
messages. The issue can be reproduced by attempting to scp a large
enough file from an SSH Target to the client. In this case the
connection gets terminated and results in a partial transfer of the
file.

This message size limit appears to be unnecessary, and the default
behavior is changing in v1.8.8 of nhooyr/websocket to make the message
size unlimited. Since this version is not yet released, this commit
switches the dependency to a fork with a version that is v1.8.7 plus the
patch to disable the limit. Once v1.8.8 is release this dependency can
be set back.

See:
    nhooyr/websocket#254
    nhooyr/websocket#256
@tmessi tmessi mentioned this pull request Oct 6, 2023
Merged
tmessi added a commit to hashicorp/boundary that referenced this pull request Oct 6, 2023
@tmessi
fix(cli): Remove websocket message size limit
52f6a03 
When the boundary client establishes a connection to the websocket used
to communicate with a worker, it was configured with a max websocket
message size of 32KiB. This was the default behavior for v1.8.7 of
nhooyr/websocket. However, there are cases where the worker can send
messages to the client that are larger than 32KiB. When this happens the
client returns an error and terminates the connection.

Notably this seems to only currently impact sessions made to SSH
Targets, although it could theoretically impact any target type
depending on the details of how the worker performs the writing of the
messages. The issue can be reproduced by attempting to scp a large
enough file from an SSH Target to the client. In this case the
connection gets terminated and results in a partial transfer of the
file.

This message size limit appears to be unnecessary, and the default
behavior is changing in v1.8.8 of nhooyr/websocket to make the message
size unlimited. Since this version is not yet released, this commit
switches the dependency to a fork with a version that is v1.8.7 plus the
patch to disable the limit. Once v1.8.8 is release this dependency can
be set back.

See:
    nhooyr/websocket#254
    nhooyr/websocket#256
tmessi added a commit to hashicorp/boundary that referenced this pull request Oct 6, 2023
@tmessi
fix(cli): Remove websocket message size limit (#3808)
88bb253 
When the boundary client establishes a connection to the websocket used
to communicate with a worker, it was configured with a max websocket
message size of 32KiB. This was the default behavior for v1.8.7 of
nhooyr/websocket. However, there are cases where the worker can send
messages to the client that are larger than 32KiB. When this happens the
client returns an error and terminates the connection.

Notably this seems to only currently impact sessions made to SSH
Targets, although it could theoretically impact any target type
depending on the details of how the worker performs the writing of the
messages. The issue can be reproduced by attempting to scp a large
enough file from an SSH Target to the client. In this case the
connection gets terminated and results in a partial transfer of the
file.

This message size limit appears to be unnecessary, and the default
behavior is changing in v1.8.8 of nhooyr/websocket to make the message
size unlimited. Since this version is not yet released, this commit
switches the dependency to a fork with a version that is v1.8.7 plus the
patch to disable the limit. Once v1.8.8 is release this dependency can
be set back.

See:
    nhooyr/websocket#254
    nhooyr/websocket#256
tmessi added a commit to hashicorp/boundary that referenced this pull request Oct 6, 2023
@tmessi
fix(cli): Remove websocket message size limit (#3808)
481de09 
When the boundary client establishes a connection to the websocket used
to communicate with a worker, it was configured with a max websocket
message size of 32KiB. This was the default behavior for v1.8.7 of
nhooyr/websocket. However, there are cases where the worker can send
messages to the client that are larger than 32KiB. When this happens the
client returns an error and terminates the connection.

Notably this seems to only currently impact sessions made to SSH
Targets, although it could theoretically impact any target type
depending on the details of how the worker performs the writing of the
messages. The issue can be reproduced by attempting to scp a large
enough file from an SSH Target to the client. In this case the
connection gets terminated and results in a partial transfer of the
file.

This message size limit appears to be unnecessary, and the default
behavior is changing in v1.8.8 of nhooyr/websocket to make the message
size unlimited. Since this version is not yet released, this commit
switches the dependency to a fork with a version that is v1.8.7 plus the
patch to disable the limit. Once v1.8.8 is release this dependency can
be set back.

See:
    nhooyr/websocket#254
    nhooyr/websocket#256
(cherry picked from commit 88bb253)
nhooyr added a commit that referenced this pull request Oct 25, 2023
@nhooyr
ws_js.go: Disable read limit on -1
454aee8 
Whoops, updates #254 and closes #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nhooyr