diff --git a/accept_test.go b/accept_test.go index 707aabd3..29975617 100644 --- a/accept_test.go +++ b/accept_test.go @@ -419,22 +419,6 @@ func Test_selectDeflate(t *testing.T) { }, expOK: true, }, - // { - // name: "x-webkit-deflate-frame", - // mode: CompressionNoContextTakeover, - // reqSecWebSocketExtensions: "x-webkit-deflate-frame; no_context_takeover", - // respSecWebSocketExtensions: "x-webkit-deflate-frame; no_context_takeover", - // expCopts: &compressionOptions{ - // clientNoContextTakeover: true, - // serverNoContextTakeover: true, - // }, - // }, - // { - // name: "x-webkit-deflate/error", - // mode: CompressionNoContextTakeover, - // reqSecWebSocketExtensions: "x-webkit-deflate-frame; max_window_bits", - // error: true, - // }, } for _, tc := range testCases { diff --git a/compress.go b/compress.go index ee21e1d1..81de751b 100644 --- a/compress.go +++ b/compress.go @@ -12,11 +12,7 @@ import ( // CompressionMode represents the modes available to the deflate extension. // See https://tools.ietf.org/html/rfc7692 // -// A compatibility layer is implemented for the older deflate-frame extension used -// by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06 -// It will work the same in every way except that we cannot signal to the peer we -// want to use no context takeover on our side, we can only signal that they should. -// But it is currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218 +// Works in all browsers except Safari which does not implement the deflate extension. type CompressionMode int const ( diff --git a/ws_js.go b/ws_js.go index 9f0e19e9..e60601e3 100644 --- a/ws_js.go +++ b/ws_js.go @@ -485,12 +485,7 @@ func CloseStatus(err error) StatusCode { // CompressionMode represents the modes available to the deflate extension. // See https://tools.ietf.org/html/rfc7692 -// -// A compatibility layer is implemented for the older deflate-frame extension used -// by safari. See https://tools.ietf.org/html/draft-tyoshino-hybi-websocket-perframe-deflate-06 -// It will work the same in every way except that we cannot signal to the peer we -// want to use no context takeover on our side, we can only signal that they should. -// It is however currently disabled due to Safari bugs. See https://github.com/nhooyr/websocket/issues/218 +// Works in all browsers except Safari which does not implement the deflate extension. type CompressionMode int const (