Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's quite dumb and not effective class that processes all DotNode nodes in query and tries to parse them as constants (load them via reflection)
Example of query where it's needed:
nhibernate-core/src/NHibernate.Test/Legacy/FooBarTest.cs
Line 4292 in 8f05f67
Where
FooStatus.OFF
string is transformed to actual enum value.ContstantConverter
tries to convert bothf.Status
andFooStatus.OFF
to constant valueInstead fix existing logic present in DotNode that makes reflection calls and checks only when necessary.