Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConstantConverter #3395

Merged
merged 3 commits into from
Aug 6, 2023

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Aug 4, 2023

That's quite dumb and not effective class that processes all DotNode nodes in query and tries to parse them as constants (load them via reflection)

Example of query where it's needed:

q = s.CreateQuery("from Foo as f where f.Status = FooStatus.OFF");

Where FooStatus.OFF string is transformed to actual enum value. ContstantConverter tries to convert both f.Status and FooStatus.OFF to constant value

Instead fix existing logic present in DotNode that makes reflection calls and checks only when necessary.

@bahusoid bahusoid merged commit 2d77480 into nhibernate:master Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants