Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of select queries for each ManyToMany not found ignored element in hql #3394

Merged
merged 12 commits into from
Aug 4, 2023
Merged

Get rid of select queries for each ManyToMany not found ignored element in hql #3394

merged 12 commits into from
Aug 4, 2023
+124 −73

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Aug 3, 2023 •
edited
Loading

Use table group join with inner joined entity table for many-to-many not-found="ignore" mapping:

FROM Device device0_
LEFT OUTER JOIN (
	DriveOfDevice drives1_ 
	INNER JOIN Drive drive2_ ON drives1_.DriveId = drive2_.id
	) ON device0_.id = drives1_.DeviceId

bahusoid and others added 11 commits August 3, 2023 15:06
@bahusoid
Test case
437008d
@bahusoid
Fix
70d9322
@github-actions
Generate async files

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
373d8b2
@bahusoid
Try fixing failed tests
1c3ca91
@github-actions
Generate async files
81a6d66
@bahusoid
Fix tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
7d5e3b4
@github-actions
Generate async files

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e584f49
@bahusoid
Remove test ignore

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
55f83f8
@bahusoid
Fix DeepSource
bc4e33a
@github-actions
Generate async files
c30cece
@bahusoid
Commented
01f47c4
@fredericDelaporte fredericDelaporte added this to the 5.5 milestone Aug 3, 2023
@bahusoid bahusoid merged commit a7deeb0 into nhibernate:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte

Assignees
No one assigned
Labels
c: Core p: Minor r: Fixed t: Improvement
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bahusoid @fredericDelaporte