Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NHibernate.Example.Web project #3379

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Remove NHibernate.Example.Web project #3379

merged 5 commits into from
Jul 24, 2023
+0 −763

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Jul 24, 2023 •
edited
Loading

It is outdated and not maintained.

hazzik added 3 commits July 24, 2023 23:43
@hazzik
Remove Serilog

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5ad00aa
@hazzik
Use SQLite as default provider for the example project

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
198dd1f
@hazzik
Update example project to .NET Core 2.1
78fd756
@bahusoid
Copy link
Member

I don't understand why it's part of nhibernate-core. Let's move it to separate project.

@hazzik hazzik changed the title Cleanup Example App Remove NHibernate.Example.Web project Jul 24, 2023
@hazzik
Copy link
Member Author

hazzik commented Jul 24, 2023 •
edited
Loading

@bahusoid removed altogether

@bahusoid
Copy link
Member

Can we drop it too?

nhibernate-core/.github/renovate.json

Lines 23 to 32 in 5f6069a

{
"matchPackageNames": [
"Microsoft.AspNetCore",
"Microsoft.AspNetCore.Mvc",
"Microsoft.AspNetCore.Mvc.Razor.ViewCompilation",
"Microsoft.AspNetCore.StaticFiles"
],
"groupName": "Microsoft.AspNetCore 2.0",
"allowedVersions": "~2.1.0"
},

@hazzik
Copy link
Member Author

hazzik commented Jul 24, 2023

@bahusoid done

@hazzik hazzik added this to the 5.5 milestone Jul 24, 2023
@hazzik hazzik enabled auto-merge (squash) July 24, 2023 22:20
@hazzik hazzik disabled auto-merge July 24, 2023 22:20
@hazzik hazzik merged commit 7a1bf08 into nhibernate:master Jul 24, 2023
@hazzik hazzik deleted the example branch July 24, 2023 22:21
@fredericDelaporte fredericDelaporte changed the title Remove NHibernate.Example.Web project Remove NHibernate.Example.Web project Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte

@bahusoid bahusoid

Assignees
No one assigned
Labels
c: Documentation p: Lowest r: Fixed t: Task
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hazzik @bahusoid @fredericDelaporte