Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify aggregateDistinctAll rule in Hql.g #3374

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Jul 22, 2023

Syntatic predicate is replaced with Semantic predicate to help antlr with parsing (which avoids double parsing for this rule)

@bahusoid bahusoid changed the title Simplify aggregateDistinctAll hql lexer rule Simplify aggregateDistinctAll rule in Hql.g Jul 23, 2023
hazzik
hazzik previously approved these changes Jul 23, 2023
bahusoid added 2 commits July 23, 2023 16:43

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bahusoid bahusoid enabled auto-merge (squash) July 24, 2023 06:31
@hazzik hazzik added this to the 5.5 milestone Jul 24, 2023
@bahusoid bahusoid disabled auto-merge July 24, 2023 10:54
@bahusoid bahusoid enabled auto-merge (squash) July 24, 2023 14:49
@bahusoid bahusoid merged commit d578b1d into nhibernate:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants