fix(eslint-plugin): do not report non-array returns in no-multiple-actions-in-effects (#4418)

Author: jsaguet

Diff for: modules/eslint-plugin/spec/rules/effects/no-multiple-actions-in-effects.spec.ts

@@ -94,6 +94,24 @@ export const saveSearchCriteria$ = createEffect(
   { functional: true }
 );
   `,
+  `
+import { Actions, createEffect, ofType } from '@ngrx/effects';
+import { createAction, props } from '@ngrx/store';
+import { of, switchMap } from 'rxjs';
+const foo = createAction('foo', props<{ payload: string }>());
+const bar = createAction('bar');
+const baz = createAction('baz');
+
+@Injectable()
+export class Effects {
+  constructor(private actions$: Actions) {}
+  effect$ = createEffect(() =>
+        this.actions$.pipe(
+            ofType(foo),
+            switchMap(({ payload }: { payload: string }) => (payload === 'value' ? of(bar()) : of(baz()))),
+        ),
+    );
+}`,
 ];
 
 const invalid: () => RunTests['invalid'] = () => [

Diff for: modules/eslint-plugin/src/rules/effects/no-multiple-actions-in-effects.ts

@@ -58,7 +58,7 @@ export default createRule<Options, MessageIds>({
           });
         } else if (
           type.isUnion() &&
-          type.types.some((ut) => !typeChecker.isArrayType(ut))
+          type.types.some((ut) => typeChecker.isArrayType(ut))
         ) {
           context.report({
             node: nodeToReport,