-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move destroyInactiveTabPanel prop to Tabs instead of Tab #3130
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WalkthroughThe recent update introduces a new property Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant TabsComponent
participant TabPanel
User->>TabsComponent: Switch Tab
TabsComponent->>TabPanel: Check destroyInactiveTabPanel
alt destroyInactiveTabPanel is true
TabsComponent->>TabPanel: Destroy Inactive Tab Panel
else destroyInactiveTabPanel is false
TabsComponent->>TabPanel: Keep Inactive Tab Panel
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
apps/docs/content/docs/components/tabs.mdx (1)
Line range hint
105-105
: Consider adding a hyphen to "client side" to form the compound adjective "client-side".This adjustment will improve the grammatical accuracy of the documentation. Here's the suggested change:
- current URL from your client side router. + current URL from your client-side router.
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/docs/content/docs/components/tabs.mdx (2 hunks)
Additional Context Used
LanguageTool (1)
apps/docs/content/docs/components/tabs.mdx (1)
Near line 105: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...cted tab with the current URL from your client side router. You can do this by doing the fo...
Rule ID: EN_COMPOUND_ADJECTIVE_INTERNAL
Additional comments not posted (1)
apps/docs/content/docs/components/tabs.mdx (1)
268-268
: Clarification ondestroyInactiveTabPanel
property is well-documented.This addition clearly explains the functionality of the
destroyInactiveTabPanel
property, enhancing the documentation's accuracy and usefulness for developers.
Closes #
📝 Description
destroyInactiveTabPanel
is a prop forTabs
, notTab
.⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
destroyInactiveTabPanel
property to theTabs
component, allowing users to control whether inactive tab panels should be destroyed when switching tabs.