Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.3.2/2.1 - Mobile (responsive) view - The elements of the menu (Dashboard, Files, etc.) do not immediately receive screen reader focus after the menu is opened, but rather as the last elements on the page, as they are at the very bottom in the DOM order. (9) #36924

Closed
12 tasks done
AndyScherzinger opened this issue Feb 28, 2023 · 2 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility

Comments

@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility labels Feb 28, 2023
@Pytal Pytal self-assigned this Apr 28, 2023
@Pytal
Copy link
Member

Pytal commented Apr 28, 2023

Works on master and https://try.nextcloud.com/ltd/a11y/index.php with menu entries receiving screen reader focus on open

Can you confirm that the menu is accessible on https://try.nextcloud.com/ltd/a11y/index.php @michaelnissenbaum?

The container element is still at the bottom of the DOM though as it's a v-popper

Focus is not trapped though so a checkbox has been added to the description

@Pytal Pytal added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Apr 28, 2023
@michaelnissenbaum
Copy link

The elements of the menu now receive keyboard and screen reader focus in the correct order. This issue appears to be resolved. Please ensure that the menu itself is correctly implemented with the appropriate elements/roles. Currently, for example, ARIA role="menu" has been used even though this is not an application menu, and the implementation is not complete. For further information, please refer to https://inclusive-components.design/menus-menu-buttons/.

@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 11, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 9, 2023
@Pytal Pytal closed this as completed Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Development

No branches or pull requests

3 participants