Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated NcMultiselect and NcMultiselectTags components #4281

Merged
merged 1 commit into from Jun 27, 2023
Merged

Remove deprecated NcMultiselect and NcMultiselectTags components #4281

merged 1 commit into from Jun 27, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 27, 2023

☑️ Resolves

Now that #3743 was implemented, we can finally remove the deprecated NcMultiselect and NcMultiselectTags components.

Migration guide:
Use NcSelect and NcSelectTags instead.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@susnux
chore: Remove deprecated NcMultiselect and NcMultiselectTags comp…
6e574de 
…onents

Use `NcSelect` and `NcSelectTags` instead.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews feature: select Related to the NcSelect* components breaking PR that requires a new major version labels Jun 27, 2023
@susnux susnux added this to the 8.0.0 milestone Jun 27, 2023
@susnux susnux requested review from raimund-schluessler, skjnldsv and a team June 27, 2023 12:02
raimund-schluessler
raimund-schluessler approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@susnux susnux merged commit a7131ea into master Jun 27, 2023
17 checks passed
@susnux susnux deleted the chore/remore-nc-multiselect branch June 27, 2023 18:57
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews breaking PR that requires a new major version feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Remove NcMultiselect component
3 participants
@susnux @raimund-schluessler @skjnldsv