Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix progress-bar on chromium browsers #4238

Merged
merged 2 commits into from Jun 21, 2023
Merged

fix progress-bar on chromium browsers #4238

merged 2 commits into from Jun 21, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Jun 20, 2023 •
edited

Close #4199

Browser Before After
Chromium image image
Firefox image image

@szaimen
fix progress-bar on chromium browsers
2de6e99 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added the 2. developing Work in progress label Jun 20, 2023
@szaimen szaimen added this to the 8.0.0 milestone Jun 20, 2023
@szaimen szaimen added enhancement New feature or request 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 20, 2023
@szaimen szaimen marked this pull request as ready for review June 20, 2023 09:11
@szaimen szaimen requested review from jancborchardt, raimund-schluessler, marcoambrosini, nimishavijay, a team, susnux, artonge and Pytal and removed request for a team June 20, 2023 09:11
@szaimen
Copy link
Contributor Author

szaimen commented Jun 20, 2023

/backport to stable7

@szaimen @artonge
address review
2eec3d6 
Signed-off-by: Simon L <szaimen@e.mail.de>

Co-authored-by: Louis <6653109+artonge@users.noreply.github.com>
Signed-off-by: Simon L. <szaimen@e.mail.de>
nimishavijay
nimishavijay approved these changes Jun 20, 2023
View reviewed changes
Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@szaimen szaimen merged commit d8aa491 into master Jun 21, 2023
16 checks passed
@szaimen szaimen deleted the enh/noid/fix-progress-bar branch June 21, 2023 00:06
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 21, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Improve design of progress bar
4 participants
@szaimen @jancborchardt @artonge @nimishavijay