Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): Hide clear and deselect when disabled #4212

Merged
merged 1 commit into from Jun 14, 2023
Merged

fix(NcSelect): Hide clear and deselect when disabled #4212

merged 1 commit into from Jun 14, 2023

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jun 14, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@Pytal
fix(NcSelect): Hide clear and deselect when disabled
697971a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug Something isn't working 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Jun 14, 2023
@Pytal Pytal added this to the 8.0.0 milestone Jun 14, 2023
@Pytal Pytal self-assigned this Jun 14, 2023
szaimen
szaimen approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChristophWurst
ChristophWurst approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ChristophWurst ChristophWurst merged commit 5d1e7f3 into master Jun 14, 2023
16 checks passed
@ChristophWurst ChristophWurst deleted the fix/select-x-button branch June 14, 2023 10:14
@Pytal
Copy link
Contributor Author

Pytal commented Jun 14, 2023

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 14, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug Something isn't working feature: select Related to the NcSelect* components
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Disabled NcSelect should not render clickable "x" for each selected option
4 participants
@Pytal @ChristophWurst @raimund-schluessler @szaimen