Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcProviderList): Add padding around provider list #4175

Merged
merged 1 commit into from Jun 9, 2023

Conversation

juliushaertl
Copy link
Contributor

Since the padding on the modal itself was removed it should still be added to the provider list when opening the picker with getLinkWithPicker

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Screenshot 2023-06-02 at 15 44 28 Screenshot 2023-06-02 at 15 44 22

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • πŸ“˜ Component documentation has been extended, updated or is not applicable

Signed-off-by: Julius HΓ€rtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Waiting for reviews labels Jun 2, 2023
@juliushaertl
Copy link
Contributor Author

/backport to stable7

Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ πŸ’™

@juliushaertl juliushaertl requested review from mejo- and Hephi2 June 9, 2023 15:32
@juliushaertl juliushaertl merged commit d7447f8 into master Jun 9, 2023
16 checks passed
@juliushaertl juliushaertl deleted the fix/provider-list-padding branch June 9, 2023 17:05
@skjnldsv skjnldsv mentioned this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants