[stable7] Revert new AppSidebarTabs design #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
nickvergessen,
marcelklehr,
susnux and
raimund-schluessler
skjnldsv
added
bug
nickvergessen
approved these changes
May 5, 2023
|
If this change is generally desired, just not for version 7, how about branching-of a stable7 branch and reverting it just there? |
marcelklehr
approved these changes
May 5, 2023
That is exactly what we did, this PR here is against stable7 |
nickvergessen
changed the title
|
Is the revert on the |
Sorry, I missed that 🙈 |
I kinda don't want to take risks tbh 🤷 |
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable 7 should not have such drastic changes so close to the freeze or the design will look different between apps as no one have time to update yet.
Revert #3945