Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichContenteditable): Completely stop event propagation for keyup events #3937

Merged
merged 1 commit into from Mar 28, 2023
Merged

fix(NcRichContenteditable): Completely stop event propagation for keyup events #3937

merged 1 commit into from Mar 28, 2023

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen commented Mar 28, 2023 •
edited

Steps

  1. Open http://localhost:6060/#/Components/NcRichContenteditable
  2. Paste @Test01 or inserting emoji into the input
  3. Check that there is no dangeling Tribute in the top left

grafik

Seems there was yet another event triggering the tribute.

With the given modification the problem does not occur anymore.

Seems that preventDefault() (from vue .prevent) is not enough.

@nickvergessen
fix(NcRichContenteditable): Completely stop event propagation for key…
299a372 
…up events

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 28, 2023
@nickvergessen nickvergessen added this to the 7.8.5 milestone Mar 28, 2023
@nickvergessen nickvergessen self-assigned this Mar 28, 2023
@nickvergessen nickvergessen merged commit 563318c into master Mar 28, 2023
15 checks passed
@nickvergessen nickvergessen deleted the bugfix/3913/stop-eating-input branch March 28, 2023 12:14
This was referenced Mar 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
7.8.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickvergessen @skjnldsv @Antreesy