Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichContenteditable): prevent tribute from opening on keyup #3917

Merged
merged 1 commit into from Mar 23, 2023
Merged

fix(NcRichContenteditable): prevent tribute from opening on keyup #3917

merged 1 commit into from Mar 23, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Mar 23, 2023 •
edited

Tribute is listening to keyup, but we don't need this.

How to reproduce:

  1. Start writing a completion @al
  2. Cancel with Escape
  3. Paste a sentence starting with a space Lorep Ipsum
  4. See the tribute opening on the top left of the screen

Alternative way of reproducing the issue:

  1. Paste some string starting with a valid mention like @all lorem ipsum
  2. See the tribute opening on the top left of the screen

Now:

  • The tribute popup does not opens

@skjnldsv
fix(NcRichContenteditable): prevent tribute from opening on keyup
e8711ef 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 23, 2023
@skjnldsv skjnldsv self-assigned this Mar 23, 2023
@nickvergessen nickvergessen mentioned this pull request Mar 23, 2023
Closed
nickvergessen
nickvergessen approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧙

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 23, 2023
@nickvergessen nickvergessen merged commit 5e0f8aa into master Mar 23, 2023
15 checks passed
@nickvergessen nickvergessen deleted the fix/richcontent-tribute-keyup branch March 23, 2023 15:28
@nickvergessen nickvergessen mentioned this pull request Mar 24, 2023
Closed
@nickvergessen nickvergessen added this to the 7.8.4 milestone Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
7.8.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skjnldsv @nickvergessen @Antreesy @blizzz