Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcRichContenteditable): Fix pasting XML and HTML content #3915

Merged
merged 1 commit into from Mar 23, 2023
Merged

fix(NcRichContenteditable): Fix pasting XML and HTML content #3915

merged 1 commit into from Mar 23, 2023

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen added bug Something isn't working 2. developing Work in progress feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 23, 2023
@nickvergessen nickvergessen self-assigned this Mar 23, 2023
@nickvergessen nickvergessen mentioned this pull request Mar 23, 2023
Closed
@nickvergessen nickvergessen marked this pull request as ready for review March 23, 2023 11:49
@nickvergessen nickvergessen added 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. and removed 2. developing Work in progress labels Mar 23, 2023
@nickvergessen nickvergessen added this to the 7.8.3 milestone Mar 23, 2023
@nickvergessen
fix(NcRichContenteditable): Fix pasting XML and HTML content
35c79ee 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/3264/fix-pasting-xml-content branch from ce4c9e9 to 35c79ee Compare March 23, 2023 14:11
Antreesy
Antreesy approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.createTextNode also allows to escape HTML characters, so there is no need to do it twice

julien-nc
julien-nc approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems safe to me too.

@nickvergessen nickvergessen merged commit 1dcc51d into master Mar 23, 2023
15 checks passed
@nickvergessen nickvergessen deleted the bugfix/3264/fix-pasting-xml-content branch March 23, 2023 14:41
@Antreesy Antreesy mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
7.8.3
Development

Successfully merging this pull request may close these issues.

Can't paste XML into chats NcRichContentEditable can not handle HTML a like input
4 participants
@nickvergessen @julien-nc @skjnldsv @Antreesy