Fix missing NcVNodes import in NcListItem #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
added
bug
raimund-schluessler
approved these changes
Mar 20, 2023
|
@raimund-schluessler Thanks for the review. How about |
You are right, I forgot to import it, and didn't notice it because in the docs all
I don't think so. |
julien-nc
added
3. to review
GretaD
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raimund-schluessler When using
NcListItemin https://github.com/julien-nc/integration_miro/blob/main/src/components/talk/SendModal.vue#L31-L49 we get this error:This appeared with
@nextcloud/vue7.8.1.If I'm right about the fix, this PR might need some more changes to deal with the undefined
router-linkin<component :is="to ? 'router-link' : 'NcVNodes'"