Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add slot for description of NcEmptyContent #3895

Merged
merged 1 commit into from May 23, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 15, 2023

Like the title this allows to override the default behavior of the description by providing a slot for it.
This way you could pass in formatted content (e.g. using emphasis / strong emphasis ...).

Note: Maybe move the slot inside the paragraph element?

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: emptycontent Related to the emptycontent component labels Mar 15, 2023
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, although I am a bit skeptical whether we should allow this much adjustments, or rather keep it consistent.

@susnux
Copy link
Contributor Author

susnux commented Mar 15, 2023

I know what you mean, maybe we should move the slot inside the <p> to restrict the content to inline elements.

And maybe the title should (have been) restricted to a prop accepting only h elements for different heading levels but no custom elements?

@raimund-schluessler
Copy link
Contributor

I know what you mean, maybe we should move the slot inside the <p> to restrict the content to inline elements.

And maybe the title should (have been) restricted to a prop accepting only h elements for different heading levels but no custom elements?

I think this would be to much coding effort to restrict it. Maybe we simply give a hint in the description of the slot.

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me if there's a need for this.

@susnux susnux force-pushed the feat/ncemptycontent-description-slot branch from 813be06 to 8cb61be Compare May 22, 2023 22:16
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux force-pushed the feat/ncemptycontent-description-slot branch from 8cb61be to 9b946d4 Compare May 22, 2023 22:19
@susnux
Copy link
Contributor Author

susnux commented May 22, 2023

Rebased this and added the discussed documentation comments and moved the slot inside the paragraph element.

@raimund-schluessler raimund-schluessler merged commit 7ebec9e into master May 23, 2023
16 checks passed
@raimund-schluessler raimund-schluessler deleted the feat/ncemptycontent-description-slot branch May 23, 2023 08:40
@susnux
Copy link
Contributor Author

susnux commented May 31, 2023

/backport to stable7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: emptycontent Related to the emptycontent component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants