Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting modal size when registering a custom picker component #3866

Merged

Conversation

julien-nc
Copy link
Contributor

Design review outcome: Some custom picker components don't look good in a "large" NcModal.

This allows to pass the desired modal size when registering a custom picker component.
This size is then used by NcReferencePickerModal.

@julien-nc julien-nc added enhancement New feature or request 3. to review Waiting for reviews feature: richtext Related to the richtext component labels Mar 6, 2023
@julien-nc julien-nc added this to the 7.9.0 milestone Mar 6, 2023
@julien-nc julien-nc modified the milestones: 7.9.0, 7.9.1 Apr 7, 2023
@Pytal Pytal modified the milestones: 7.9.1, 7.11.0 Apr 18, 2023
@artonge artonge modified the milestones: 7.11.0, 7.12.0 May 3, 2023
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/configurable-custom-picker-widget-modal-size branch from ce9b46e to 6b05033 Compare May 3, 2023 15:52
@nickvergessen nickvergessen modified the milestones: 7.12.0, 8.0.0 May 8, 2023
@AndyScherzinger
Copy link
Contributor

/backport to stable7

@juliushaertl
Copy link
Contributor

@julien-nc Max/Jonas are out today, do you have an app that can be used for testing this already around so we can pull in someone else for another review today?

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine by code, but didn't tested it yet

Copy link
Contributor

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Didn't test locally though.

@nickvergessen nickvergessen merged commit 0a98aca into master May 11, 2023
16 checks passed
@nickvergessen nickvergessen deleted the enh/noid/configurable-custom-picker-widget-modal-size branch May 11, 2023 11:47
@julien-nc
Copy link
Contributor Author

julien-nc commented May 11, 2023

@juliushaertl Any app implementing a custom smart picker component:

  • integration_giphy
  • integration_openstreetmap
  • integration_openai
  • integration_replicate
  • text_templates
  • files

For testing this properly:

  • the component registration must be done with this nc/vue branch
  • the modal size must be passed when registering (already done in most of the apps mentioned)
  • the app showing the smart picker should also use this nc/vue branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: richtext Related to the richtext component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants