Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify datetimepicker opacity in NcActionInput #3814

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Unify datetimepicker opacity in NcActionInput #3814

merged 1 commit into from
Feb 23, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Feb 23, 2023 •
edited

The date type of the NcActionInput component didn't have it's opacity reduced when not hovered. This PR unifies this.

Before After
Screenshot 2023-02-23 at 14-49-11 Nextcloud Vue Style Guide Screenshot 2023-02-23 at 14-49-29 Nextcloud Vue Style Guide

@raimund-schluessler
Unify datetimepicker opacity in NcActionInput
9a2f024 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler marked this pull request as ready for review February 23, 2023 13:50
@raimund-schluessler raimund-schluessler added this to the 7.8.0 milestone Feb 23, 2023
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: actions Related to the actions components design Design, UX, interface and interaction design labels Feb 23, 2023
@mejo-
Copy link
Contributor

mejo- commented Feb 23, 2023

To be honest I don't see a visual difference in the ActionInput items in your screenshot 😆

@raimund-schluessler
Copy link
Contributor Author

To be honest I don't see a visual difference in the ActionInput items in your screenshot 😆

It is quite subtle and only affects the input of type date (the third last in the screenshot, the one without a proper border yet). It is a bit more visible in the docs when actually hovering the items.

mejo-
mejo- approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, I got it now 😊

@raimund-schluessler raimund-schluessler merged commit 4ed91f2 into master Feb 23, 2023
@raimund-schluessler raimund-schluessler deleted the fix/noid/action-input-date-style branch February 23, 2023 14:59
@raimund-schluessler raimund-schluessler mentioned this pull request Feb 23, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@Pytal Pytal Awaiting requested review from Pytal

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@mejo- mejo- Awaiting requested review from mejo-

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design feature: actions Related to the actions components
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raimund-schluessler @mejo- @susnux