Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcSelect): Do not squash selected items with no-wrap set #3811

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix(NcSelect): Do not squash selected items with no-wrap set #3811

merged 1 commit into from
Feb 22, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 22, 2023 •
edited

I think this resolves the issue, does this looks like you would expect it to look with no-wrap set?

before after
image image
vokoscreenNG-2023-02-22_15-57-26.mp4

@susnux
fix(NcSelect): Do not squash selected items with no-wrap set
f31f0bc 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux added bug Something isn't working 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: select Related to the NcSelect* components labels Feb 22, 2023
jancborchardt
jancborchardt approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this look like you would expect it to look with no-wrap set?

Yup, I would say so! Better than truncating each one of the elements. :)

@mejo-
Copy link
Contributor

mejo- commented Feb 22, 2023

Thanks a lot for the quick fix @susnux ❤️

@mejo- mejo- merged commit f30342a into master Feb 22, 2023
@mejo- mejo- deleted the fix/ncselect-nowrap branch February 22, 2023 16:13
@nickvergessen nickvergessen mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@mejo- mejo- mejo- approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NcSelect with :no-wrap="true" styling broken
3 participants
@susnux @mejo- @jancborchardt