Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcAppNavigation - change toggle icon for opened sidebar #3800

Merged

Conversation

Antreesy
Copy link
Contributor

Closes #3688

Changed icon for NcAppNavigationToggle in open state with more visually and semantically appropiate icon

Before After
image Screenshot from 2023-02-20 16-24-35

@Antreesy Antreesy added enhancement New feature or request 3. to review Waiting for reviews feature: app-navigation Related to the app-navigation component design Design, UX, interface and interaction design labels Feb 20, 2023
@Antreesy Antreesy self-assigned this Feb 20, 2023
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the feature/3688/close-icon-for-app-navigation-toggle branch from 7078ee7 to 848603f Compare February 20, 2023 15:37
Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@raimund-schluessler raimund-schluessler merged commit 0531fa6 into master Feb 20, 2023
@raimund-schluessler raimund-schluessler deleted the feature/3688/close-icon-for-app-navigation-toggle branch February 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UX, interface and interaction design enhancement New feature or request feature: app-navigation Related to the app-navigation component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppNavigationToggle component - changing icon on toggle
4 participants