Fix package exports #543
Merged
Fix package exports #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… module resolution to import the package Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/package-exports
branch
from
a6e63a9
to
ea0e8be
Compare
ChristophWurst
approved these changes
Jun 15, 2023
| @@ -2,17 +2,30 @@ | |||
| "name": "@nextcloud/initial-state", | |||
| "version": "2.0.0", | |||
| "description": "Access data from the nextcloud server-side initial state API within apps.", | |||
| "homepage": "https://github.com/nextcloud/nextcloud-initial-state#readme", | |||
| "author": "Christoph Wurst", | |||
There was a problem hiding this comment.
are you sure about that?
There was a problem hiding this comment.
I can undo this, it just "hurt my eye" that the package.json was like meta data -> scripts -> metadata -> dependencies 😅
There was a problem hiding this comment.
I'm not actively maintaining this package so I think it would not make a lot of sense to list me as the author
There was a problem hiding this comment.
I did just move it, not added it 😉
You already were mentioned as author.
ChristophWurst
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix package exports to support typescript projects with
nodenextornode16module resolution.Also move some parts of the
package.jsonto the to (group metadata).