Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide changelog with release + drop unused .npmignore #630

Merged
merged 1 commit into from Jun 27, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 27, 2023

Drop unneeded .npmignore -> already overridden by files section of package.json

…ection of `package.json`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv
Copy link
Contributor

Is the changelog necessary in a production package?

@susnux
Copy link
Contributor Author

susnux commented Jun 27, 2023

I personally would say yes, the changelog, license and the readme should always be provided.

@skjnldsv
Copy link
Contributor

I don't think it's really accessible, but I don't mind it being here.
Just unsure if that's useful 🙈

Feel free to merge 💪

@susnux susnux merged commit cc2b0f9 into master Jun 27, 2023
4 checks passed
@susnux susnux deleted the chore/npmignore branch June 27, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants