Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcPopover): auto return focus to trigger button on close #5155

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(NcPopover): auto return focus to trigger button on close #5155

wants to merge 1 commit into from
+34 −9

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 27, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 Tasks

  • Automatically find a button inside the NcPopover trigger and use it as fallback for setReturnFocus
  • Add noAutoReturnFocus to optionally disable this behavior
    • Useful when there is a custom focus control, like in NcActions
  • Adjust NcActions

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable

@ShGKme
feat(NcPopover): auto return focus to trigger button on close
be836c0 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews feature: popover Related to the popovermenu component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 27, 2024
@ShGKme ShGKme self-assigned this Jan 27, 2024
@ShGKme ShGKme added this to the 8.8.2 milestone Feb 29, 2024
@juliushaertl juliushaertl modified the milestones: 8.8.2, 8.9.1 Mar 6, 2024
@Pytal Pytal modified the milestones: 8.9.1, 8.9.2 Mar 6, 2024
@ShGKme ShGKme modified the milestones: 8.9.2, 8.10.0, 8.10.1, 8.11.0 Mar 8, 2024
@ShGKme ShGKme modified the milestones: 8.11.0, 8.11.1 Mar 15, 2024
@Antreesy Antreesy removed this from the 8.11.1 milestone Mar 21, 2024
@Antreesy Antreesy added this to the 8.11.2 milestone Mar 21, 2024
@Antreesy Antreesy modified the milestones: 8.11.2, 8.11.3 Apr 11, 2024
@Antreesy Antreesy modified the milestones: 8.11.3, 8.11.4 May 7, 2024
@susnux susnux modified the milestones: 8.11.4, 8.13.0 May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request feature: popover Related to the popovermenu component
Projects
None yet
Milestone
8.13.0
Development

Successfully merging this pull request may close these issues.

[NcEmojiPicker] is losing focus after close
5 participants
@ShGKme @susnux @juliushaertl @Pytal @Antreesy