Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release 8.4.0 #4987

Merged
merged 1 commit into from Dec 27, 2023
Merged

chore: Release 8.4.0 #4987

merged 1 commit into from Dec 27, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 22, 2023

v8.4.0 (2023-12-22)

Full Changelog

Notes

  • NcRichContenteditable: new visual label feature might break layout if you have custom contenteditable styles
  • isMobile and isFullscreen mixins are now deprecated, use useIsMobile and useIsFullscreen composables instead

🚀 Enhancements

🐛 Fixed bugs

Other Changes

@ChristophWurst
Copy link
Contributor

Is this the first release with full Vue 3 support? #3692 (comment)

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

Is this the first release with full Vue 3 support? #3692 (comment)

No, we should make v9.0.0-alpha.1 release later from next branch.

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

But I forgot to mention deprecated stuff in the changelog.

@ahangarha
Copy link
Contributor

Let me know if you think we should have logical CSS properties fully added in this release, and you can wait for one more week. Otherwise, they will be added in the next release.

Copy link
Contributor

@ahangarha ahangarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a proposition for changing the category of #4965

* fix(NcAppSettingsDialog): respect showNavigation prop by @ShGKme in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4954
* fix(NcAppNavigation): Bring back hover state for active element by @susnux in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4960
* enh(aria): changed check color to adhere to 3:1 ratio by @emoral435 in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4958
* Use logical style for NcHeaderMenu by @ahangarha in https://github.com/nextcloud-libraries/nextcloud-vue/pull/4965
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this PR should be categorized under bug fixes. I see it more as adding new capability to the UI to adjust itself to the direction of its context.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a bug if it does not work for some languages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call it definitely a bug fix. The component didn't work correctly. A new feature is a new component/function or new feature of a component with a new property/event and ect.

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

Let me know if you think we should have logical CSS properties fully added in this release, and you can wait for one more week. Otherwise, they will be added in the next release.

We always can make a new library release when needed, so we can just make 8.4.1 release next week or in 2 weeks. Next Nextcloud server release is planned for 25 Jan 2024 anyway.

@susnux
Copy link
Contributor

susnux commented Dec 22, 2023

But we can also wait for next year to get some more in as there will not much updating anyways

@ahangarha
Copy link
Contributor

Nextcloud server release is planned for 25 Jan 2024 anyway.

In any case, I would like to have all the logical style fixes before the NextCloud-server release so that it can use these styles. In any case, I should hurry up 🙂 🏃🏾‍♂️

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme marked this pull request as ready for review December 27, 2023 13:08
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 27, 2023
@ShGKme ShGKme added this to the 8.4.0 milestone Dec 27, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 27, 2023

Rebased on master and to include one bug fix and great split translations enh.

@ShGKme ShGKme merged commit 7d1831a into master Dec 27, 2023
17 checks passed
@ShGKme ShGKme deleted the release/v8.4.0 branch December 27, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants