Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcSelect Timezone picker breaks on Firefox when using with NcPopover #4917

Closed
miaulalala opened this issue Dec 5, 2023 · 4 comments
Closed
Labels
0. to triage bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components

Comments

@miaulalala
Copy link
Contributor

Since the component uses a manual z-index, the component looks like this on Firefox when using it together with the NcPopover

nextcloud/calendar#5606

@susnux
Copy link
Contributor

susnux commented Dec 6, 2023

It does not have any custom stylings so this is caused by NcSelect which is used under the hood.

@susnux susnux added bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components 1. to develop Accepted and waiting to be taken care of labels Dec 6, 2023
@susnux
Copy link
Contributor

susnux commented Dec 6, 2023

@miaulalala are you sure you mounted the popover correctly?
Because something like this works

<template>
	<div style="display: flex">
		<NcPopover>
			<template #trigger>
				<NcButton>I am the trigger</NcButton>
			</template>
			<template>
				<form tabindex="0" @submit.prevent>
					<NcPopover>
						<template #trigger>
							<NcButton>I am the second trigger</NcButton>
						</template>
						<template>
							<NcTimezonePicker />
						</template>
					</NcPopover>
					<h2>this is some content</h2>
					<p>
						Lorem ipsum dolor sit amet, consectetur adipiscing elit. <br/>
						Vestibulum eget placerat velit.
					</p>
					<label>
						Label element
						<input type="text" placeholder="input element"/>
					</label>
				</form>
			</template>
		</NcPopover>
	</div>
</template>

No adjustments needed, so I guess one of your popovers is bound to a HTML element below the current popover. Are you nesting them and bind both to the body instead the second one to the first?

@susnux susnux added 0. to triage and removed 1. to develop Accepted and waiting to be taken care of labels Dec 6, 2023
@miaulalala
Copy link
Contributor Author

@st3iny
Copy link
Contributor

st3iny commented May 28, 2024

That seems to be it. Thanks again @susnux ❤️

@st3iny st3iny closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. to triage bug Something isn't working design Design, UX, interface and interaction design feature: select Related to the NcSelect* components
Projects
None yet
Development

No branches or pull requests

3 participants