Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] NcActions navigation menu detection #4681

Closed
3 tasks done
Pytal opened this issue Oct 20, 2023 · 0 comments
Closed
3 tasks done

[BITV] NcActions navigation menu detection #4681

Pytal opened this issue Oct 20, 2023 · 0 comments
Assignees
@Pytal
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working

Comments

@Pytal
Copy link
Contributor

Pytal commented Oct 20, 2023 •
edited

Some attributes that should not be present when used as a navigation menu e.g. the three-dot app menu
image
are still present

nextcloud-vue/src/components/NcActions/NcActions.vue

Line 1128 in 89048aa

'aria-haspopup': isNav ? null : 'menu',

@Pytal Pytal added bug Something isn't working accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Oct 20, 2023
@Pytal Pytal self-assigned this Oct 20, 2023
@Pytal Pytal mentioned this issue Oct 28, 2023
Merged
2 tasks
@Pytal Pytal added 2. developing Work in progress 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 28, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 17, 2023
@Pytal Pytal closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Pytal