Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: native title tooltip on NcListItem title #3687

Closed
ShGKme opened this issue Jan 27, 2023 · 3 comments
Closed

Feature request: native title tooltip on NcListItem title #3687

ShGKme opened this issue Jan 27, 2023 · 3 comments
Labels
accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Jan 27, 2023

It seems to be impossible to set the title attribute on <NcListItem>.

What about adding a nativeTitle prop or even more, adding title-tooltip feature for long titles to NcListItem?

Use case: display full title (from prop) in title (tooltip), when it is too long.

Tooltip on a long conversation name with ellipses

Related:
@ShGKme ShGKme added enhancement New feature or request accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jan 27, 2023
@ShGKme ShGKme mentioned this issue Jan 27, 2023
Merged
6 tasks
@nickvergessen
Copy link
Contributor

https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcListItem/NcListItem.vue#L140

Documentation says it's there.
I think they are automatically passed on when they are not props. So simply using title works already.

@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 27, 2023

https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcListItem/NcListItem.vue#L140

Documentation says it's there. I think they are automatically passed on when they are not props. So simply using title works already.

But title is a prop:

https://github.com/nextcloud/nextcloud-vue/blob/e65bd9247874264aa1d57d59d79f53391e31faa1/src/components/NcListItem/NcListItem.vue#L321-L327

It is used only as the text content of the title element:

https://github.com/nextcloud/nextcloud-vue/blob/e65bd9247874264aa1d57d59d79f53391e31faa1/src/components/NcListItem/NcListItem.vue#L230-L234

@Antreesy Antreesy mentioned this issue Feb 2, 2023
Closed
1 task
@Antreesy
Copy link
Contributor

Seems closed by #4106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Making sure we design for the widest range of people possible, including those who have disabilities enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickvergessen @ShGKme @Antreesy