Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better arrangement of items in "New" menu in Files #43728

Closed
14 of 19 tasks
nimishavijay opened this issue Feb 21, 2024 · 8 comments · Fixed by nextcloud-libraries/nextcloud-upload#1206
Closed
14 of 19 tasks
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap design Design, UI, UX, etc. enhancement feature: files
Milestone

Comments

@nimishavijay
Copy link
Member

nimishavijay commented Feb 21, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Uploading and adding new files and folders is one of the most common actions in Files. The most obvious way to do this is through the "New" menu. Currently, the items in this menu are simply in one big list, making it possibly difficult to find the action you are looking for. There is also a lot of repeated words (new file, new document, new spreadsheet, etc) and outdated icons are used (as we prefer material design icons)

Current state:

Describe the solution you'd like
Some small tweaks to the menu can make it look more organised and easy to find your desired action.

Before After
image image

Describe alternatives you've considered
n/a

Additional context
Also a point to note in the Files gap analysis is the grouping of new/upload actions in other products (see "Creating and uploading").

@nimishavijay nimishavijay added enhancement design Design, UI, UX, etc. 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: files ux labels Feb 21, 2024
@nimishavijay nimishavijay self-assigned this Feb 21, 2024
@susnux
Copy link
Contributor

susnux commented Feb 26, 2024

@skjnldsv this would require us to have some groups for those actions in @nextcloud/upload.
What do you think of having three defined groups UPLOAD, NEW and OTHER to sort them in?

@skjnldsv
Copy link
Member

hmmm, the two firsts are internal, so it might not be needed for those 🤔
But the last two, good idea yeah.

@AndyScherzinger
Copy link
Member

@jancborchardt jsut looking at you as kind of a replacement here: Is the text icon meant to be black, hence adapting accordingly for dark/light themes or should it be grey - like before? Thanks in advance for the feedback 🙏

@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Mar 19, 2024
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 19, 2024

-> we target v29 - just for the icon update, see #44340. Anything else could come later to keep it simple hence putting this issue on v30 as a milestone.

@jancborchardt
Copy link
Member

@jancborchardt jsut looking at you as kind of a replacement here: Is the text icon meant to be black, hence adapting accordingly for dark/light themes or should it be grey - like before? Thanks in advance for the feedback 🙏

Considering this is also used in the file list and grid view (and in the widgets) and black this would be very dark then, we should indeed keep it grey.
FYI @nimishavijay @marcoambrosini

@jancborchardt
Copy link
Member

jancborchardt commented Mar 20, 2024

Diagram: drawing-box in #ebc94a

And on this to have proper 3:1 contrast, we need to change the color to: #b39114 @nimishavijay – also works for dark theme.

@jancborchardt
Copy link
Member

Also updated in the issue at #44340 (comment)

@susnux
Copy link
Contributor

susnux commented May 15, 2024

Except for the folder description (3rd category), this is done with nextcloud-libraries/nextcloud-upload#1175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap design Design, UI, UX, etc. enhancement feature: files
Projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

6 participants