Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent repeated dialog toast messages #753

Open
theronakpatel opened this issue Jan 31, 2023 · 3 comments
Open

Prevent repeated dialog toast messages #753

theronakpatel opened this issue Jan 31, 2023 · 3 comments

Comments

@theronakpatel
Copy link

When there is an error, Nextcloud typically generates many repeated messages to the user.
We can at least modify the nextcloud-dialogs library to not show a message already on screen.
Alternatively, identify a few cases (like storage full) and buffer those on the component generating the alert.

Screenshot (4)

@nickvergessen
Copy link
Contributor

Alternatively, identify a few cases (like storage full) and buffer those on the component generating the alert.

Yeah that should be done. I don't think it's the job of the lib to deduplicate, because it can not know if that is needed or not. Maybe the user pressed another button and again receives a "No permissions" error. So it should be triggered again.

Storage notification should therefore be fixed in the files app.

@theronakpatel
Copy link
Author

@nickvergessen but cant we hide previous one first then show new notification!

@nickvergessen
Copy link
Contributor

yeah the code that creates it can do that already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants