fix: 🎣 remove trailing ? from signIn url
#8466
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@jwyce is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
client
jwyce
changed the title
jwyce
changed the title
? from redirect url
|
@balazsorban44 / @ThangHuuVu do you see any potential problems with merging this code into the next v4 patch release? |
jwyce
changed the title
? from redirect url? from signIn url
ThangHuuVu
reviewed
Sep 6, 2023
ThangHuuVu
reviewed
Sep 6, 2023
|
I think we can merge this one! Thanks for the PR, @jwyce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Fixing a weird bug where some URL categorizers that VPNs use will falsely categorize one of the sign-in redirects as phishing since the URL ends in a
?when no parameters are provided to next-auth/react'ssignIn()function.The fix was simply to not include the
?for query params when none are provided.🧢 Checklist
📌 Resources