fix(EmailProvider): proper required fields and allow all nodemailer types #7950
+45
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@reconbot is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
3 tasks
reconbot
force-pushed
the
reconbot/email-provider-types
branch
from
6dc83dd to
77e0983
Compare
reconbot
force-pushed
the
reconbot/email-provider-types
branch
from
77e0983 to
338171e
Compare
|
I've added some docs around the |
reconbot
commented
Jul 4, 2023
reconbot
commented
Jul 4, 2023
reconbot
changed the title
reconbot
changed the title
balazsorban44
requested changes
Jul 5, 2023
reconbot
force-pushed
the
reconbot/email-provider-types
branch
from
338171e to
344ba07
Compare
github-actions
bot
added
adapters
reconbot
commented
Jul 6, 2023
reconbot
force-pushed
the
reconbot/email-provider-types
branch
from
344ba07 to
52c7882
Compare
|
@balazsorban44 v4 is in great shape, reworked to merge into it |
github-actions
bot
removed
the
adapters
reconbot
commented
Jul 6, 2023
balazsorban44
approved these changes
Jul 11, 2023
3 tasks
balazsorban44
had a problem deploying
to
Preview
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
I was trying to setup the
EmailProviderwith aws'sSESand noticed the types didn't allow that, and even if I was using a normal smtp server it had incorrect required and optional fields. This change allows all types for nodemailer'screateTransport()function including premade transports (which is handy if you're usingnodemailer.createTestAccount())🧢 Checklist
🎫 Affected issues
Related: #5618 (related to but doesn't replace)