Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth): allow jwks_uri to be set for non-wellKnown flow by passin… #7014

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Conversation

petewins
Copy link
Contributor

@petewins petewins commented Mar 21, 2023

This PR allows the required field jwks_uri in Issuer to be passed into the oidc-client when wellKnown isn't used.

☕️ Reasoning

only 4 properties are passed to oidc-client. Currently jwks_uri isn't one of them leading to the error: jwks_uri must be configured on the issuer

🧢 Checklist

  • Documentation
  • Tests
  • [ x] Ready to be merged

🎫 Affected issues

Fixes #3567

📌 Resources

Sorry, something went wrong.

@petewins petewins requested a review from ThangHuuVu as a code owner March 21, 2023 02:34
@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 25, 2023 at 8:33AM (UTC)
auth-docs-nextra ❌ Failed (Inspect) Mar 25, 2023 at 8:33AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth-docs ⬜️ Ignored (Inspect) Mar 25, 2023 at 8:33AM (UTC)

@taiminenjani
Copy link

I'm having this exact workaround on my project. Merging this PR would me much appreciated.

Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for jumping in!

@ThangHuuVu ThangHuuVu merged commit aadefc6 into nextauthjs:main Mar 25, 2023
ThangHuuVu added a commit that referenced this pull request Mar 25, 2023
fix(oauth): allow jwks_uri to be set for non-wellKnown flow by passing jwks_endpoint

Co-authored-by: Thang Vu <hi@thvu.dev>
joe1chen pushed a commit to dogomedia/next-auth that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy Refers to `next-auth` v4. Minimal maintenance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring Issuer without Discovery isn't possible
3 participants