fix: TS Module Augmentation #5556
Merged
+41
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
core
balazsorban44
requested changes
Oct 11, 2022
|
🎉 Experimental release published 📦️ on npm! pnpm add next-auth@0.0.0-pr.5556.ac098ce6yarn add next-auth@0.0.0-pr.5556.ac098ce6npm i next-auth@0.0.0-pr.5556.ac098ce6 |
That's true, I matched the type of |
balazsorban44
approved these changes
Oct 12, 2022
emrysal
reviewed
Nov 22, 2022
| @@ -17,7 +17,7 @@ export interface CredentialsConfig< | |||
| authorize: ( | |||
| credentials: Record<keyof C, string> | undefined, | |||
| req: Pick<RequestInternal, "body" | "query" | "headers" | "method"> | |||
| ) => Awaitable<(Omit<User, "id"> | { id?: string }) | null> | |||
There was a problem hiding this comment.
@ThangHuuVu We use SERIAL id's as we have a PostgreSQL database coming from v3, the removal of this line triggers a type error as number is not assignable to string.
There was a problem hiding this comment.
Do we need to extend the User interface as well? @emrysal
joe1chen
pushed a commit
to dogomedia/next-auth
that referenced
this pull request
Jan 29, 2025
* commit '462cca1087135ffc89af39f1f4ad6a0007e38f7a': chore(release): bump package version(s) [skip ci] chore: remove codeql run on main push fix(ts): TS Module Augmentation (nextauthjs#5556) docs: options.md grammar fixes (nextauthjs#5562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This fixes the Module Augmentation issue:
| { email: string }part which breaks the Module Augmentation. I don't think we need it for anything 🤔. Matches that type withAdapterUserinstead.🎫 Affected issues
Fixes: #5542
📌 Resources