fix(ts): handle NextRequest type #4472
Merged
+28
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Reasoning
Following the merge of this PR #4402, the build got broken 🔥
That's because the
getToken()
implementation assumed thereq
object passed to it was an instance ofNextApiRequest
. However, the new middleware implementation:https://github.com/nextauthjs/next-auth/blob/main/packages/next-auth/src/next/middleware.ts#L56-L84
is calling this function with a
req
object which is an instance ofNextRequest
.At the end of the day:
is only interested in
cookies
andheaders
in thereq
object supplied to it. It happens though thatheaders
are different inNextApiRequest
andNextRequest
... inNextApiRequest
it'll beIncomingHttpHeaders
while inNextRequest
it'll beHeaders
and both are read differently...Random thought
Was
getToken()
working before when not called in the context of an API route?🧢 Checklist
[ ] Documentation[ ] Tests🎟 Affected issues
None