Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enforce node-naming conventions #192

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Jan 22, 2025

Summary

  • Use nightly host name prefix for EKS nodes. Still using permanent which causes nightly tests to fail.
  • Replace k8s-node with k8s_node for consistency in regular ci tests
  • Current host names reported to NR for reference
image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@kb-newrelic kb-newrelic marked this pull request as ready for review January 22, 2025 18:47
@kb-newrelic kb-newrelic requested a review from a team as a code owner January 22, 2025 18:47
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kb-newrelic kb-newrelic merged commit 408615e into main Jan 22, 2025
6 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/enforce-node-naming-conventions branch January 22, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants